Update Beam model protos with element metadata#34971
Merged
kennknowles merged 3 commits intoapache:masterfrom May 19, 2025
Merged
Update Beam model protos with element metadata#34971kennknowles merged 3 commits intoapache:masterfrom
kennknowles merged 3 commits intoapache:masterfrom
Conversation
as part of https://s.apache.org/beam-element-extended-metadata we want to add ElementMetadata that will hold in the future additional metadata fields e.g. drainMode, element kind or tracing metadata.
kennknowles
approved these changes
May 16, 2025
Member
|
Perfect starter to unblock parallel efforts on supporting it. |
kennknowles
reviewed
May 16, 2025
model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/beam_runner_api.proto
Outdated
Show resolved
Hide resolved
Contributor
|
Assigning reviewers: R: @robertwb added as fallback since no labels match configuration Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Member
|
The failed tests are unrelated. They have been deflaked at HEAD. For other code changes I might ask for a rebase and kick them until green, but this one is so small I won't :-) |
kennknowles
changed the title
This was referenced Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as part of https://s.apache.org/beam-element-extended-metadata we want to add ElementMetadata that will hold in the future additional metadata fields e.g. drainMode, element kind or tracing metadata.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.